[GitHub] [hudi] danny0405 commented on a diff in pull request #8900: [HUDI-6334] Integrate logcompaction table service to metadata table and provides various bugfixes to metadata table

[via GitHub]

danny0405 commented on code in PR #8900:
URL: https://github.com/apache/hudi/pull/8900#discussion_r1223899704


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/plan/generators/BaseHoodieCompactionPlanGenerator.java:
##########
@@ -158,7 +165,8 @@ protected List<String> 
filterPartitionPathsByStrategy(HoodieWriteConfig writeCon
     return partitionPaths;
   }
 
-  protected boolean filterFileSlice(FileSlice fileSlice, String 
lastCompletedInstantTime, Set<HoodieFileGroupId> pendingFileGroupIds) {
+  protected boolean filterFileSlice(FileSlice fileSlice, String 
lastCompletedInstantTime,
+                                    Set<HoodieFileGroupId> 
pendingFileGroupIds, Option<InstantRange> instantRange) {
     return fileSlice.getLogFiles().count() > 0 && 
!pendingFileGroupIds.contains(fileSlice.getFileGroupId());

Review Comment:
   Has the `instantRange` been used anywhere?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org