xicm commented on code in PR #8911:
URL: https://github.com/apache/hudi/pull/8911#discussion_r1227550752
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/shims/Hive3Shim.java:
##########
@@ -122,4 +126,16 @@ public long getMills(Object timestamp) {
throw new HoodieException("can not create writable v2 class!", e);
}
}
+
+ @Override
+ public PartitionDesc getPartitionDesc(Map<Path, PartitionDesc>
pathToPartitionInfo, Path dir,
+ Map<Map<Path, PartitionDesc>, Map<Path, PartitionDesc>> cacheMap) throws
IOException {
+ try {
+ Class<?> hiveUtilsClass =
Class.forName("org.apache.hadoop.hive.ql.io.HiveFileFormatUtils");
+ Method method = hiveUtilsClass.getMethod("getFromPathRecursively",
Map.class, Path.class, Map.class);
Review Comment:
Sorry for the delay, do reflection in static block.
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/shims/HiveCompatibleShimAbove23.java:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop.utils.shims;
+
+import java.io.IOException;
+import java.lang.reflect.Method;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.mapred.JobConf;
+
+/**
+ * When the hive version is greater than or equal to hive version 2.3
+ */
+public class HiveCompatibleShimAbove23 implements HiveCompatibleShim {
+
+ private static HiveCompatibleShimAbove23 INSTANCE = new
HiveCompatibleShimAbove23();
+
+ public static HiveCompatibleShim getInstance() {
+ return INSTANCE;
+ }
+
+ @Override
+ public void invokePushProjectAndFilters(JobConf job, Class<?>
inputFormatClass, Path splitPath)
+ throws IOException {
+ try {
+ Class hiveInputFormatClass = this.getClass().getSuperclass();
Review Comment:
is this right?
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/shims/HiveCompatibleShimAbove23.java:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.hadoop.utils.shims;
+
+import java.io.IOException;
+import java.lang.reflect.Method;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.mapred.JobConf;
+
+/**
+ * When the hive version is greater than or equal to hive version 2.3
+ */
+public class HiveCompatibleShimAbove23 implements HiveCompatibleShim {
+
+ private static HiveCompatibleShimAbove23 INSTANCE = new
HiveCompatibleShimAbove23();
+
+ public static HiveCompatibleShim getInstance() {
+ return INSTANCE;
+ }
+
+ @Override
+ public void invokePushProjectAndFilters(JobConf job, Class<?>
inputFormatClass, Path splitPath)
+ throws IOException {
+ try {
+ Class hiveInputFormatClass = this.getClass().getSuperclass();
+ Method pushProjectionsAndFilters =
hiveInputFormatClass.getDeclaredMethod("pushProjectionsAndFilters",
JobConf.class,
Review Comment:
The default version of hive is 2.3, can we extends `HiveInputFormat` and
call `pushProjectionsAndFilters ` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
