beyond1920 commented on code in PR #4913: URL: https://github.com/apache/hudi/pull/4913#discussion_r1231757821
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java: ########## @@ -273,4 +280,31 @@ protected static Option<IndexedRecord> toAvroRecord(HoodieRecord record, Schema return Option.empty(); } } + + protected class AppendLogWriteCallback implements HoodieLogFileWriteCallback { + // here we distinguish log files created from log files being appended. Considering following scenario: + // An appending task write to log file. + // (1) append to existing file file_instant_writetoken1.log.1 + // (2) rollover and create file file_instant_writetoken2.log.2 + // Then this task failed and retry by a new task. + // (3) append to existing file file_instant_writetoken1.log.1 + // (4) rollover and create file file_instant_writetoken3.log.2 + // finally file_instant_writetoken2.log.2 should not be committed to hudi, we use marker file to delete it. + // keep in mind that log file is not always fail-safe unless it never roll over + Review Comment: Under this case, if we use direct marker type, the new task would got an exception when it call `preLogFileOpen`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org