xuzifu666 commented on code in PR #9052: URL: https://github.com/apache/hudi/pull/9052#discussion_r1241894357
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java: ########## @@ -182,6 +182,7 @@ public Option<Path> createWithEarlyConflictDetection(String partitionPath, Strin private Option<Path> create(Path markerPath, boolean checkIfExists) { HoodieTimer timer = HoodieTimer.start(); Path dirPath = markerPath.getParent(); + boolean overwrite = false; Review Comment: i notice the param checkIfExists, and if task fail but stage not retry,would running task with the same attamptid,so duplicate marker files would create -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org