danny0405 commented on code in PR #9049:
URL: https://github.com/apache/hudi/pull/9049#discussion_r1243053950
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java:
##########
@@ -262,6 +262,7 @@ private void updateHeartbeat(String instantTime) throws
HoodieHeartbeatException
heartbeat.setLastHeartbeatTime(newHeartbeatTime);
heartbeat.setNumHeartbeats(heartbeat.getNumHeartbeats() + 1);
} catch (IOException io) {
+ LOG.error("Unable to generate heartbeat,instant:{}", instantTime, io);
throw new HoodieHeartbeatException("Unable to generate heartbeat ", io);
}
Review Comment:
We can remove the log: `LOG.error("Unable to generate heartbeat,instant:{}",
instantTime, io);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
