YannByron commented on code in PR #9068:
URL: https://github.com/apache/hudi/pull/9068#discussion_r1244640244


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/HoodieProcedureUtils.scala:
##########
@@ -43,4 +47,74 @@ object HoodieProcedureUtils {
 
     ProcedureArgs(isNamedArgs = true, map, new GenericInternalRow(values))
   }
+
+  sealed trait Operation {
+    def value: String
+    def isSchedule: Boolean = this != Execute
+    def isExecute: Boolean = this != Schedule

Review Comment:
   maybe that define two methods, and implement them in sub-classes, is more 
clear.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to