stream2000 commented on code in PR #9156:
URL: https://github.com/apache/hudi/pull/9156#discussion_r1257466066
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BucketBulkInsertDataInternalWriterHelper.java:
##########
@@ -91,27 +90,20 @@ private UTF8String extractRecordKey(InternalRow row) {
}
}
- protected HoodieRowCreateHandle getBucketRowCreateHandle(String fileId, int
bucketId) throws Exception {
- if (!handles.containsKey(fileId)) { // if there is no handle corresponding
to the fileId
Review Comment:
The fileid passed here is actually partitonPath, so
`handles.containsKey(fileId)` is always true for record in the same partition
thus no new handle will be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
