danny0405 commented on code in PR #8054:
URL: https://github.com/apache/hudi/pull/8054#discussion_r1257693948
##########
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/util/SparkDataSourceTableUtils.java:
##########
@@ -34,13 +35,21 @@
import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.BINARY;
public class SparkDataSourceTableUtils {
+
+ public static Map<String, String> getSparkTableProperties(List<String>
partitionNames, String sparkVersion,
+ int
schemaLengthThreshold, MessageType schema) {
+ return getSparkTableProperties(partitionNames, sparkVersion,
schemaLengthThreshold, schema, Collections.emptyMap());
+ }
+
/**
* Get Spark Sql related table properties. This is used for spark datasource
table.
- * @param schema The schema to write to the table.
+ *
+ * @param schema The schema to write to the table.
* @return A new parameters added the spark's table properties.
*/
public static Map<String, String> getSparkTableProperties(List<String>
partitionNames, String sparkVersion,
- int
schemaLengthThreshold, MessageType schema) {
+ int
schemaLengthThreshold, MessageType schema,
+ Map<String,
String> commentMap) {
Review Comment:
Where does the new method be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
