[GitHub] [hudi] stream2000 commented on a diff in pull request #9160: [HUDI-6501] HoodieHeartbeatClient should close without stopping all heartbeats started via this instance of the client

[via GitHub]

stream2000 commented on code in PR #9160:
URL: https://github.com/apache/hudi/pull/9160#discussion_r1258103624


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java:
##########
@@ -201,14 +196,6 @@ public void stop(String instantTime) throws 
HoodieException {
     }
   }
 
-  /**
-   * Stops all heartbeats started via this instance of the client.
-   * @throws HoodieException
-   */
-  public void stop() throws HoodieException {
-    instantToHeartbeatMap.values().forEach(heartbeat -> 
stop(heartbeat.getInstantTime()));

Review Comment:
   We need to at least stop timers for the existing heartbeats



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org