SteNicholas commented on code in PR #9160:
URL: https://github.com/apache/hudi/pull/9160#discussion_r1259146107
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestBase.java:
##########
@@ -770,6 +770,7 @@ protected void updateBatchWithoutCommit(String
newCommitTime, List<HoodieRecord>
HoodieWriteConfig hoodieWriteConfig =
getConfigBuilder(HoodieFailedWritesCleaningPolicy.LAZY)
.withAutoCommit(false) // disable auto commit
.withRollbackUsingMarkers(true)
+ .withHeartbeatTolerableMisses(0)
.build();
Review Comment:
@danny0405, accelerate the expiration of the heartbeat for the deltacommit
and not wait for the heartbeat expiration in [line
308](https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestSavepointRestoreMergeOnRead.java#L308)
for `TestSavepointRestoreMergeOnRead#testCleaningCompletedRollback`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
