danny0405 commented on code in PR #9158:
URL: https://github.com/apache/hudi/pull/9158#discussion_r1260505794
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/HoodieSparkEngineContext.java:
##########
@@ -207,15 +206,15 @@ public void putCachedDataIds(HoodieDataCacheKey cacheKey,
int... ids) {
@Override
public List<Integer> getCachedDataIds(HoodieDataCacheKey cacheKey) {
synchronized (cachedRddIds) {
- return cachedRddIds.getOrDefault(cacheKey, Collections.emptyList());
+ return cachedRddIds.getOrDefault(cacheKey, new ArrayList<>());
Review Comment:
> Another way, I can new a ArrayList to addAll items, just like:
This is always better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
