lw309637554 edited a comment on pull request #1756: URL: https://github.com/apache/hudi/pull/1756#issuecomment-650096565
> Took a quick pass at the three test classes you have added.. LGTM . > Will do a detailed pass once you confirm PR is indeed ready.. @vinothchandar hello，i have add more test for end to end rollback. And the all hudi unit test passed. There are a few questions to discuss with you: 1. for rollback successful commit, in HoodieWriteClient.java i remove the deleteMarkerDir() in postcommit when is in usingmarkers mode. But it will double the file numbers in dfs. 2. if the markers file retain, if we should clean it when the datafile is cleaned, also if we should archive the markers file when archiveCommitsWith if these two question clear and solved, i think the patch will be ok .Then i will add a new patch that will not conflict with the master. Thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
