xushiyan commented on PR #9221: URL: https://github.com/apache/hudi/pull/9221#issuecomment-1649394492
> Hi @xushiyan, I noticed the casting from hadoopConf to hiveConf was introduced by this PR from you(#6202) but I couldn't find any context. Could you help me learn why we made that change? > > ``` > HiveConf hiveConf = hadoopConf instanceof HiveConf > ? (HiveConf) hadoopConf : new HiveConf(hadoopConf, HiveConf.class); > ``` hey @CTTY it's probably meant for being fully compatible with the original code, as it was done for refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
