danny0405 commented on code in PR #9211: URL: https://github.com/apache/hudi/pull/9211#discussion_r1274284407
########## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java: ########## @@ -114,10 +116,28 @@ public void testCheckpointFails() throws Exception { } @Test - public void testSubtaskFails() throws Exception { + public void testSubtaskFailsWithEagerFailedWritesCleanPolicy() throws Exception { + testSubtaskFails() + // the last checkpoint instant was rolled back by subTaskFails(0, 2) + // with EAGER cleaning strategy + .assertNoEvent() Review Comment: Can we add new tests instead of modifying existing one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org