danny0405 commented on code in PR #9229:
URL: https://github.com/apache/hudi/pull/9229#discussion_r1274291759
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java:
##########
@@ -101,6 +104,12 @@ public static class Config implements Serializable {
public String runningMode = null;
@Parameter(names = {"--strategy", "-st"}, description = "Strategy Class",
required = false)
public String strategyClassName =
LogFileSizeBasedCompactionStrategy.class.getName();
+ @Parameter(names = {"--job-max-processing-time-ms", "-mt"}, description =
"Take effect when using --mode/-m execute or scheduleAndExecute. "
+ + "If maxProcessingTimeMs passed but compaction job is still
unfinished, hoodie would consider this job as failed and relaunch.")
+ public long maxProcessingTimeMs = 0;
+ @Parameter(names = {"--retry-last-failed-compaction-job", "-rc"},
description = "Take effect when using --mode/-m execute or scheduleAndExecute. "
Review Comment:
> the failed inflight compaction plan which will never been re-run
Can we fix that rollback by including the inflight compactions instead of
introducing new config options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
