amrishlal commented on code in PR #9324: URL: https://github.com/apache/hudi/pull/9324#discussion_r1280982125
########## pom.xml: ########## @@ -98,8 +98,6 @@ <fasterxml.jackson.databind.version>${fasterxml.spark3.version}</fasterxml.jackson.databind.version> <fasterxml.jackson.module.scala.version>${fasterxml.spark3.version}</fasterxml.jackson.module.scala.version> <fasterxml.jackson.dataformat.yaml.version>${fasterxml.spark3.version}</fasterxml.jackson.dataformat.yaml.version> - <!-- NOTE: By default we're not including JSR310 module for Jackson since Spark >= 3.x is bundling it anyway --> - <fasterxml.jackson.datatype.jsr310.module/> Review Comment: It seems like the original intention was to not shade JSR310 module when spark version >= 3.3. All other jackson packages that are used are already being shaded. It didn't look like this special treatement for JSR310 package was needed, so this line is being removed to shade JSR310 just like any other jackson package that is being used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org