[GitHub] [hudi] Zouxxyy commented on a diff in pull request #9332: [HUDI-6625] Lazy create metadata and viewManager in HoodieTable

[via GitHub]

Zouxxyy commented on code in PR #9332:
URL: https://github.com/apache/hudi/pull/9332#discussion_r1281464112


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/storage/row/TestHoodieRowCreateHandle.java:
##########
@@ -187,7 +187,9 @@ public void testInstantiationFailure(boolean 
enableMetadataTable) {
 
     try {
       HoodieTable table = HoodieSparkTable.create(cfg, context, metaClient);
-      new HoodieRowCreateHandle(table, cfg, " def", 
UUID.randomUUID().toString(), "001", RANDOM.nextInt(100000), RANDOM.nextLong(), 
RANDOM.nextLong(), SparkDatasetTestUtils.STRUCT_TYPE);
+      table.getMetadata();
+      // After #8452, the exception is caused by the creating of metadata in 
HoodieTable
+      // new HoodieRowCreateHandle(table, cfg, " def", 
UUID.randomUUID().toString(), "001", RANDOM.nextInt(100000), RANDOM.nextLong(), 
RANDOM.nextLong(), SparkDatasetTestUtils.STRUCT_TYPE);

Review Comment:
   Changes in this place will be reverted, see 
https://github.com/apache/hudi/pull/9310. Keep it like this for now and repair 
it when revert?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org