the-other-tim-brown commented on code in PR #9337: URL: https://github.com/apache/hudi/pull/9337#discussion_r1283557623
########## hudi-common/src/main/java/org/apache/hudi/common/model/HoodieBaseFile.java: ########## @@ -52,14 +61,45 @@ public HoodieBaseFile(String filePath) { public HoodieBaseFile(String filePath, BaseFile bootstrapBaseFile) { super(filePath); this.bootstrapBaseFile = Option.ofNullable(bootstrapBaseFile); + String[] fileIdAndCommitTime = getFileIdAndCommitTimeFromFileName(); + this.fileId = fileIdAndCommitTime[0]; + this.commitTime = fileIdAndCommitTime[1]; + } + + /** + * Parses the file ID and commit time from the fileName. + * @return String array of size 2 with fileId as the first and commitTime as the second element. + */ + private String[] getFileIdAndCommitTimeFromFileName() { Review Comment: Do you see any other places that would require this? I can add it and update callers if so, but I wanted to avoid adding more to that class if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org