nsivabalan commented on code in PR #9359:
URL: https://github.com/apache/hudi/pull/9359#discussion_r1283833724
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -194,9 +194,9 @@ trait ProvidesHoodieConfig extends Logging {
val insertMode =
InsertMode.of(combinedOpts.getOrElse(DataSourceWriteOptions.SQL_INSERT_MODE.key,
DataSourceWriteOptions.SQL_INSERT_MODE.defaultValue()))
val insertModeSet = combinedOpts.contains(SQL_INSERT_MODE.key)
- val sqlWriteOperationOpt = combinedOpts.get(SQL_WRITE_OPERATION.key())
+ val sqlWriteOperationOpt =
combinedOpts.get(SPARK_SQL_INSERT_INTO_OPERATION.key())
val sqlWriteOperationSet = sqlWriteOperationOpt.nonEmpty
- val sqlWriteOperation =
sqlWriteOperationOpt.getOrElse(SQL_WRITE_OPERATION.defaultValue())
+ val sqlWriteOperation =
sqlWriteOperationOpt.getOrElse(SPARK_SQL_INSERT_INTO_OPERATION.defaultValue())
Review Comment:
minor.
can we rename the method deduceSqlWriteOperation to
deduceSparkSqlInsetIntoWriteOperation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
