xushiyan commented on code in PR #9280:
URL: https://github.com/apache/hudi/pull/9280#discussion_r1284041034


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -420,7 +421,9 @@ abstract class HoodieBaseRelation(val sqlContext: 
SQLContext,
           inMemoryFileIndex.listFiles(partitionFilters, dataFilters)
         }
 
-        val fsView = new HoodieTableFileSystemView(metaClient, timeline, 
partitionDirs.flatMap(_.files).toArray)
+        // fail time travel query when covers hollow commit
+        val completedTimeline = handleHollowCommitIfNeeded(timeline, 
metaClient, HollowCommitHandling.FAIL)

Review Comment:
   covered in 
org.apache.hudi.functional.TestTimeTravelQuery#testTimeTravelQueryWithIncompleteCommit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to