danny0405 commented on code in PR #9209:
URL: https://github.com/apache/hudi/pull/9209#discussion_r1287874876
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##########
@@ -603,53 +327,4 @@ private boolean deleteArchivedInstants(List<HoodieInstant>
archivedInstants, Hoo
return true;
}
-
- public void archive(HoodieEngineContext context, List<HoodieInstant>
instants) throws HoodieCommitException {
- try {
- Schema wrapperSchema = HoodieArchivedMetaEntry.getClassSchema();
- LOG.info("Wrapper schema " + wrapperSchema.toString());
- List<IndexedRecord> records = new ArrayList<>();
- for (HoodieInstant hoodieInstant : instants) {
- try {
- deleteAnyLeftOverMarkers(context, hoodieInstant);
- records.add(convertToAvroRecord(hoodieInstant));
- if (records.size() >= this.config.getCommitArchivalBatchSize()) {
- writeToFile(wrapperSchema, records);
- }
- } catch (Exception e) {
- LOG.error("Failed to archive commits, .commit file: " +
hoodieInstant.getFileName(), e);
- if (this.config.isFailOnTimelineArchivingEnabled()) {
- throw e;
- }
- }
- }
- writeToFile(wrapperSchema, records);
- } catch (Exception e) {
- throw new HoodieCommitException("Failed to archive commits", e);
- }
- }
-
- private void deleteAnyLeftOverMarkers(HoodieEngineContext context,
HoodieInstant instant) {
Review Comment:
To `ArchivedTimelineWriter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
