jonvex commented on code in PR #9422:
URL: https://github.com/apache/hudi/pull/9422#discussion_r1300217569
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestMORColstats.java:
##########
@@ -237,24 +232,27 @@ private void
testBaseFileAndLogFileUpdateMatchesHelper(Boolean shouldAsyncCompac
doWrite(updatedRecord);
if (shouldRollback) {
deleteLatestDeltacommit();
+ enableInlineCompaction(shouldInlineCompact);
Review Comment:
That's how I was originally tying to do it, but the behavior with the
rollback was strange. If I set `hoodie.compact.inline.max.delta.commits` to 4
the compaction was not happening, but if I set it to 3 it would happen too
early. So that's why I set the value to 1 and do it right before the last write
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
