majian1998 commented on code in PR #9472: URL: https://github.com/apache/hudi/pull/9472#discussion_r1304195108
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/ReplaceCommitValidateUtil.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.table.action.cluster; + +import org.apache.hudi.common.model.HoodieReplaceCommitMetadata; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.util.JsonUtils; +import org.apache.hudi.exception.HoodieException; + +import java.util.Arrays; +import java.util.HashSet; +import java.util.List; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Stream; + +import static org.apache.hudi.common.util.FileIOUtils.LOG; + +public class ReplaceCommitValidateUtil { + public static final String REPLACE_COMMIT_FILE_IDS = "replaceCommitFileIds"; + public static void validateReplaceCommit(HoodieTableMetaClient metaClient) { + metaClient.reloadActiveTimeline(); + Set<String> replaceFileids = new HashSet<>(); + + // Verify pending and completed replace commit + Stream.concat(metaClient.getActiveTimeline().getCompletedReplaceTimeline().getInstantsAsStream(), + metaClient.getActiveTimeline().filterInflights().filterPendingReplaceTimeline().getInstantsAsStream()).map(instant -> { + try { + HoodieReplaceCommitMetadata replaceCommitMetadata = + HoodieReplaceCommitMetadata.fromBytes(metaClient.getActiveTimeline().getInstantDetails(instant).get(), + HoodieReplaceCommitMetadata.class); Review Comment: Thanks for your suggestion! I think your suggestion is very helpful, and if the details are implemented, it can indeed solve the same problem. However, my implementation is actually slightly different. I believe my implementation will be more lightweight, as it won't rely on the OCC framework and won't require locking. If locks are involved in the replace commit, do we still need to go through a series of lock configurations? Moreover, I think OCC solves the problem of rolling back when two files modify the same file id, which can be optional. On the other hand, my solution addresses the problem of two replace commits simultaneously deleting the same file id. If this situation occurs, it will result in incorrect table state, and the entire table will be unable to perform any operations, such as queries resulting in errors. Therefore, I don't think this check should be categorized as an optional OCC write check, but should be enabled at all times. Regarding the issue mentioned by @boneanxs , I have already addressed it, and I don't think it will occur under my check. Do you think my modification can achieve the effect I mentioned? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
