Zouxxyy commented on code in PR #9554:
URL: https://github.com/apache/hudi/pull/9554#discussion_r1307090034
##########
hudi-spark-datasource/hudi-spark-common/pom.xml:
##########
@@ -228,6 +228,19 @@
<scope>test</scope>
</dependency>
+ <!-- Hive -->
Review Comment:
If this is not added, the compilation will fail in the spark2 profile with
`class not found`, see
https://github.com/apache/hudi/actions/runs/5994914337/job/16257181299
Because in `CreateHoodieTableCommand`'s `classOf[HoodieParquetInputFormat]`
need to load `SelfDescribingInputFormatInterface`:
```scala
val inputFormat = tableType match {
case DataSourceWriteOptions.COW_TABLE_TYPE_OPT_VAL =>
classOf[HoodieParquetInputFormat].getCanonicalName
case DataSourceWriteOptions.MOR_TABLE_TYPE_OPT_VAL =>
classOf[HoodieParquetRealtimeInputFormat].getCanonicalName
case _=> throw new IllegalArgumentException(s"UnKnow table
type:$tableType")
}
```
Compile successfully with Spark3 profile, because in spark3, spark-hive_2.12
depends on hive-exec:
```text
[INFO] +- org.apache.spark:spark-hive_2.12:jar:3.4.1:provided
[INFO] | +- org.apache.hive:hive-exec:jar:core:2.3.1:provided
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
