yihua commented on code in PR #9559: URL: https://github.com/apache/hudi/pull/9559#discussion_r1309276400
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/RunIndexActionExecutor.java: ########## @@ -100,6 +105,11 @@ public class RunIndexActionExecutor<T, I, K, O> extends BaseActionExecutor<T, I, public RunIndexActionExecutor(HoodieEngineContext context, HoodieWriteConfig config, HoodieTable<T, I, K, O> table, String instantTime) { super(context, config, table, instantTime); this.txnManager = new TransactionManager(config, table.getMetaClient().getFs()); + if (config.getMetadataConfig().enableMetrics()) { + this.metrics = Option.of(new HoodieMetadataMetrics(Registry.getRegistry("HoodieIndexer", this.getClass().getSimpleName()))); Review Comment: The second argument of `getRegistry` call should be an implementation class of `Registry`, e.g., `DistributedRegistry.class.getName()`, not `this.getClass`/`RunIndexActionExecutor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org