[GitHub] [hudi] danny0405 commented on a diff in pull request #9584: [HUDI-6808] SkipCompaction Config should not affect the stream read of the cow table

[via GitHub]

danny0405 commented on code in PR #9584:
URL: https://github.com/apache/hudi/pull/9584#discussion_r1312442629


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -601,9 +602,9 @@ public List<HoodieInstant> filterInstantsWithRange(
    * @return the filtered timeline
    */
   @VisibleForTesting
-  public HoodieTimeline filterInstantsAsPerUserConfigs(HoodieTimeline 
timeline) {
+  public HoodieTimeline filterInstantsAsPerUserConfigs(HoodieTimeline 
timeline, HoodieTableType tableType) {
     final HoodieTimeline oriTimeline = timeline;
-    if (this.skipCompaction) {
+    if (OptionsResolver.isMorTable(this.conf) & this.skipCompaction) {

Review Comment:
   There is no need to pass around the `HoodieTableType` now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org