lokeshj1703 commented on code in PR #9473:
URL: https://github.com/apache/hudi/pull/9473#discussion_r1319786494
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/IncrSourceHelper.java:
##########
@@ -130,7 +130,7 @@ public static QueryInfo generateQueryInfo(JavaSparkContext
jssc, String srcBaseP
}
});
- String previousInstantTime = beginInstantTime;
+ String previousInstantTime = DEFAULT_BEGIN_TIMESTAMP;
if (!beginInstantTime.equals(DEFAULT_BEGIN_TIMESTAMP)) {
Option<HoodieInstant> previousInstant =
activeCommitTimeline.findInstantBefore(beginInstantTime);
if (previousInstant.isPresent()) {
Review Comment:
`beginInstantTime == 000` case would already be handled by current
implementation
`String previousInstantTime = beginInstantTime;`.
It seems the problem is because of if statement here? There are two cases I
could think of where `previousInstantTime` is not set to correct previous
instant :-
1. `beginInstantTime` is the first commit in activeTimeline. In such a case
we should also include archived timeline for polling the instant before.
2. `beginInstantTime` is the first commit in archivedTimeline. In this case
we will need to set it to `DEFAULT_BEGIN_TIMESTAMP`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
