yihua commented on code in PR #9746:
URL: https://github.com/apache/hudi/pull/9746#discussion_r1330977295


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMemoryConfig.java:
##########
@@ -57,13 +53,17 @@ public class HoodieMemoryConfig extends HoodieConfig {
   public static final ConfigProperty<String> 
MAX_MEMORY_FRACTION_FOR_COMPACTION = ConfigProperty
       .key("hoodie.memory.compaction.fraction")
       .defaultValue(String.valueOf(0.6))
+      .withAlternatives("compaction.memory.fraction")

Review Comment:
   `compaction.memory.fraction` is used in `HoodieRealtimeConfig` before, in 
multiple places.  Since it's not hard to make it backward compatible, I still 
keep it so that the user does not have to change the config name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to