[GitHub] [hudi] Zouxxyy commented on a diff in pull request #9770: [MINOR] Fix the check for connector identity in HoodieHiveCatalog

[via GitHub]

Zouxxyy commented on code in PR #9770:
URL: https://github.com/apache/hudi/pull/9770#discussion_r1334927198


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -455,8 +456,9 @@ public void createTable(ObjectPath tablePath, 
CatalogBaseTable table, boolean ig
       throw new DatabaseNotExistException(getName(), 
tablePath.getDatabaseName());
     }
 
-    if (!table.getOptions().getOrDefault(CONNECTOR.key(), 
"").equalsIgnoreCase("hudi")) {
-      throw new HoodieCatalogException(String.format("The %s is not hoodie 
table", tablePath.getObjectName()));

Review Comment:
   This exeception is only throwed when using `create table options(connection 
= 'xxx')` and `xxx != HoodieTableFactory.FACTORY_ID`, user just need to know 
the correct FACTORY_ID, `tablePath.getObjectName()` no need to bo in the error 
message



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org