boneanxs commented on PR #9617:
URL: https://github.com/apache/hudi/pull/9617#issuecomment-1732227136
@danny0405 The trino test failure is caused by trino image always use an old
hudi-trino-bundle jar:
we can see `/usr/local/trino/plugin/hive/hudi-trino-bundle.jar`
```bash
root@trino-coordinator-1:/usr/local/trino-server-368# ls -larth
${TRINO_HOME}/plugin/hive/hudi-trino-bundle.jar
-rw-r--r-- 1 root root 14M Jan 12 2022
/usr/local/trino/plugin/hive/hudi-trino-bundle.jar
```
but from presto image, the new built jar is used.
```bash
root@presto-coordinator-1:/opt/presto-server-0.271# ls -larth
${PRESTO_HOME}/plugin/hive-hadoop2/hudi-presto-bundle.jar
-rw-r--r-- 1 root root 42M Sep 23 06:04
/opt/presto-server-0.271/plugin/hive-hadoop2/hudi-presto-bundle.jar
```
We need to add explicitly copy command to copy the built jar to
`/usr/local/trino/plugin/hive/` just like presto image does in the entrypoint
```bash
# presto entrypoint.sh(docker/hoodie/hadoop/prestobase/bin/entrypoint.sh)
# Copy the presto bundle at run time so that locally built bundle overrides
the one that is present in the image
cp ${HUDI_PRESTO_BUNDLE} ${PRESTO_HOME}/plugin/hive-hadoop2/
```
we need to add this also in the trino entrypoint
```bash
#docker/hoodie/hadoop/trinobase/scripts/trino.sh
cp ${HUDI_TRINO_BUNDLE} ${TRINO_HOME}/plugin/hive/
```
Given this pr changed the timeline format, so old jar will fail to parse
instants and return wrong results. We may need to change `trino.sh` and rebuild
the image whereas the `intergration-tests` can use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
