danny0405 commented on code in PR #9617: URL: https://github.com/apache/hudi/pull/9617#discussion_r1343399866
########## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimeGeneratorBase.java: ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table.timeline; + +import org.apache.hudi.common.config.HoodieTimeGeneratorConfig; +import org.apache.hudi.common.config.LockConfiguration; +import org.apache.hudi.common.config.SerializableConfiguration; +import org.apache.hudi.common.lock.LockProvider; +import org.apache.hudi.common.util.ReflectionUtils; +import org.apache.hudi.exception.HoodieLockException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Serializable; +import java.util.concurrent.TimeUnit; + +import static org.apache.hudi.common.config.LockConfiguration.DEFAULT_LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS; +import static org.apache.hudi.common.config.LockConfiguration.DEFAULT_LOCK_ACQUIRE_NUM_RETRIES; +import static org.apache.hudi.common.config.LockConfiguration.DEFAULT_LOCK_ACQUIRE_WAIT_TIMEOUT_MS; +import static org.apache.hudi.common.config.LockConfiguration.LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP_KEY; +import static org.apache.hudi.common.config.LockConfiguration.LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS_PROP_KEY; +import static org.apache.hudi.common.config.LockConfiguration.LOCK_ACQUIRE_WAIT_TIMEOUT_MS_PROP_KEY; + +/** + * Base time generator facility that maintains lock-related utilities. + */ +public abstract class TimeGeneratorBase implements TimeGenerator, Serializable { + + private static final Logger LOG = LoggerFactory.getLogger(TimeGeneratorBase.class); + + /** + * The lock provider. + */ + private volatile LockProvider lockProvider; + /** + * The maximum times to retry in case there are failures. + */ + private final int maxRetries; + /** + * The maximum time to wait for each time generation to resolve the clock skew issue on distributed hosts. + */ + private final long maxWaitTimeInMs; + /** + * The maximum time to block for acquiring a lock. + */ + private final int lockAcquireWaitTimeInMs; + + protected final HoodieTimeGeneratorConfig config; + private final LockConfiguration lockConfiguration; + + /** + * The hadoop configuration. + */ + private final SerializableConfiguration hadoopConf; + + public TimeGeneratorBase(HoodieTimeGeneratorConfig config, SerializableConfiguration hadoopConf) { + this.config = config; + this.lockConfiguration = config.getLockConfiguration(); + this.hadoopConf = hadoopConf; + + maxRetries = lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_CLIENT_NUM_RETRIES_PROP_KEY, + Integer.parseInt(DEFAULT_LOCK_ACQUIRE_NUM_RETRIES)); + lockAcquireWaitTimeInMs = lockConfiguration.getConfig().getInteger(LOCK_ACQUIRE_WAIT_TIMEOUT_MS_PROP_KEY, + Integer.parseInt(DEFAULT_LOCK_ACQUIRE_WAIT_TIMEOUT_MS)); + maxWaitTimeInMs = lockConfiguration.getConfig().getLong(LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS_PROP_KEY, + Long.parseLong(DEFAULT_LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS)); + } + + protected LockProvider getLockProvider() { + // Perform lazy initialization of lock provider only if needed + if (lockProvider == null) { + synchronized (this) { + if (lockProvider == null) { + String lockProviderClass = lockConfiguration.getConfig().getString("hoodie.write.lock.provider"); + LOG.info("LockProvider for TimeGenerator: " + lockProviderClass); + lockProvider = (LockProvider) ReflectionUtils.loadClass(lockProviderClass, + lockConfiguration, hadoopConf.get()); + } + } + } + return lockProvider; + } + + public void lock() { Review Comment: Yeah, I think we can have a refactoring to the failure retries code snippet, maybe we can abstrac it out into a utilitiy method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
