linliu-code commented on code in PR #9581:
URL: https://github.com/apache/hudi/pull/9581#discussion_r1349217024
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -752,6 +752,14 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "The class must be a subclass of
`org.apache.hudi.callback.HoodieClientInitCallback`."
+ "By default, no Hudi client init callback is executed.");
+ public static final ConfigProperty<Boolean> WRITE_RECORD_POSITIONS =
ConfigProperty
+ .key("hoodie.write.record.positions")
+ .defaultValue(false)
+ .markAdvanced()
+ .sinceVersion("1.0.0")
+ .withDocumentation("Whether to write record positions to the block
header for data blocks containing updates and delete blocks. "
+ + "The record positions can be used to improve the performance of
merging records from base and log files.");
Review Comment:
After we turn on this config, does it mean Hudi will definitely do
position-based merging? Or writing positions and position-based merging are
separate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
