danny0405 commented on code in PR #9118: URL: https://github.com/apache/hudi/pull/9118#discussion_r1357583122
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkStreamWriteMetrics.java: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metrics; + +import org.apache.hudi.sink.common.AbstractStreamWriteFunction; + +import com.codahale.metrics.SlidingWindowReservoir; +import org.apache.flink.dropwizard.metrics.DropwizardHistogramWrapper; +import org.apache.flink.dropwizard.metrics.DropwizardMeterWrapper; +import org.apache.flink.metrics.Histogram; +import org.apache.flink.metrics.Meter; +import org.apache.flink.metrics.MetricGroup; + +/** + * Metrics for flink stream write (including append write, normal/bucket stream write etc.). + * Used in subclasses of {@link AbstractStreamWriteFunction}. + */ +public class FlinkStreamWriteMetrics extends HoodieFlinkMetrics { + private static final String DATA_FLUSH_KEY = "data_flush"; + private static final String FILE_FLUSH_KEY = "file_flush"; + private static final String HANDLE_CREATION_KEY = "handle_creation"; + + /** + * Flush data costs during checkpoint. + */ + private long dataFlushCosts; + + /** + * Number of records written in during a checkpoint window. + */ + protected long writtenRecords; + + /** + * Current write buffer size in StreamWriteFunction. + */ + private long writeBufferedSize; + + /** + * Total costs for closing write handles during a checkpoint window. + */ + private long fileFlushTotalCosts; + + /** + * Number of handles opened during a checkpoint window. Increased with partition number/bucket number etc. + */ + private long numOfOpenHandle; + + /** + * Number of files written during a checkpoint window. + */ + private long numOfFilesWritten; + + /** + * Number of records written per seconds. + */ + protected final Meter recordWrittenPerSecond; + + /** + * Number of write handle switches per seconds. + */ + private final Meter handleSwitchPerSecond; + + /** + * Cost of write handle creation. + */ + private final Histogram handleCreationCosts; + + /** + * Cost of a file flush. + */ + private final Histogram fileFlushCost; + + public FlinkStreamWriteMetrics(MetricGroup metricGroup) { + super(metricGroup); + this.recordWrittenPerSecond = new DropwizardMeterWrapper(new com.codahale.metrics.Meter()); + this.handleSwitchPerSecond = new DropwizardMeterWrapper(new com.codahale.metrics.Meter()); + this.handleCreationCosts = new DropwizardHistogramWrapper(new com.codahale.metrics.Histogram(new SlidingWindowReservoir(100))); + this.fileFlushCost = new DropwizardHistogramWrapper(new com.codahale.metrics.Histogram(new SlidingWindowReservoir(100))); + } + + @Override + public void registerMetrics() { + metricGroup.meter("recordWrittenPerSecond", recordWrittenPerSecond); + metricGroup.gauge("currentCommitWrittenRecords", () -> writtenRecords); + metricGroup.gauge("dataFlushCosts", () -> dataFlushCosts); + metricGroup.gauge("writeBufferedSize", () -> writeBufferedSize); + + metricGroup.gauge("fileFlushTotalCosts", () -> fileFlushTotalCosts); + metricGroup.gauge("numOfFilesWritten", () -> numOfFilesWritten); + metricGroup.gauge("numOfOpenHandle", () -> numOfOpenHandle); + + metricGroup.meter("handleSwitchPerSecond", handleSwitchPerSecond); + + metricGroup.histogram("handleCreationCosts", handleCreationCosts); + metricGroup.histogram("handleCloseCosts", fileFlushCost); + } Review Comment: handleCloseCosts -> fileFlushCosts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
