danny0405 commented on code in PR #9853:
URL: https://github.com/apache/hudi/pull/9853#discussion_r1357639219
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeCompactedRecordReader.java:
##########
@@ -198,7 +197,7 @@ private Option<HoodieAvroIndexedRecord>
mergeRecord(HoodieRecord<?> newRecord, A
GenericRecord genericRecord =
HiveAvroSerializer.rewriteRecordIgnoreResultCheck(oldRecord,
getLogScannerReaderSchema());
HoodieRecord record = new HoodieAvroIndexedRecord(genericRecord);
Option<Pair<HoodieRecord, Schema>> mergeResult =
HoodieAvroRecordMerger.INSTANCE.merge(record,
- genericRecord.getSchema(), newRecord, getLogScannerReaderSchema(), new
TypedProperties(payloadProps));
+ genericRecord.getSchema(), newRecord, getLogScannerReaderSchema(),
payloadProps);
Review Comment:
`TypedProperties` itself is serializable, it should be a mistake, in
HUDI-6937, we found a performance regression of almost 100% for parquet file
from insert handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
