beyond1920 commented on code in PR #9850:
URL: https://github.com/apache/hudi/pull/9850#discussion_r1357983985
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java:
##########
@@ -540,9 +541,7 @@ public void testWriteMultiWriterInvolved() throws Exception
{
.checkWrittenData(EXPECTED3, 1);
// step to commit the 2nd txn, should throw exception
// for concurrent modification of same fileGroups
- pipeline1.checkpoint(1)
- .assertNextEvent()
- .checkpointCompleteThrows(1, HoodieWriteConflictException.class,
"Cannot resolve conflicts");
+ testConcurrentCommit(pipeline1);
Review Comment:
The behavior of existed test cases (`testWriteMultiWriterInvolved` and
`testWriteMultiWriterPartialOverlapping`) change after support non-blocking
multiple writers. So those two tests need to be updated.
I also add some new tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
