yihua commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1361379762
##########
hudi-common/src/main/java/org/apache/hudi/common/config/LockConfiguration.java:
##########
@@ -35,19 +35,23 @@ public class LockConfiguration implements Serializable {
public static final String
LOCK_ACQUIRE_RETRY_MAX_WAIT_TIME_IN_MILLIS_PROP_KEY = LOCK_PREFIX +
"max_wait_time_ms_between_retry";
public static final String
LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS_PROP_KEY = LOCK_PREFIX +
"client.wait_time_ms_between_retry";
+ public static final String
DEFAULT_LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS = String.valueOf(5000L);
Review Comment:
Wrt this PR, is this refactoring existing code? We have common lock configs
in `HoodieLockConfig` class.
##########
hudi-common/src/main/java/org/apache/hudi/common/config/LockConfiguration.java:
##########
@@ -35,19 +35,23 @@ public class LockConfiguration implements Serializable {
public static final String
LOCK_ACQUIRE_RETRY_MAX_WAIT_TIME_IN_MILLIS_PROP_KEY = LOCK_PREFIX +
"max_wait_time_ms_between_retry";
public static final String
LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS_PROP_KEY = LOCK_PREFIX +
"client.wait_time_ms_between_retry";
+ public static final String
DEFAULT_LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS = String.valueOf(5000L);
Review Comment:
@danny0405 @boneanxs ^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
