danny0405 commented on code in PR #9904:
URL: https://github.com/apache/hudi/pull/9904#discussion_r1372556576


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestData.java:
##########
@@ -503,6 +503,20 @@ public static String rowDataToString(List<RowData> rows) {
   public static void writeData(
       List<RowData> dataBuffer,
       Configuration conf) throws Exception {
+    writeData(dataBuffer, conf, 1);
+  }
+
+  /**
+   * Write a list of row data with Hoodie format base on the given 
configuration.
+   *
+   * @param dataBuffer The data buffer to write
+   * @param conf       The flink configuration
+   * @param ckpId      The checkpoint id
+   * @throws Exception if error occurs
+   */
+  public static void writeData(
+          List<RowData> dataBuffer,

Review Comment:
   The checkpoint id does not affect the data write, there is no need to 
specify it explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to