danny0405 commented on PR #9886:
URL: https://github.com/apache/hudi/pull/9886#issuecomment-1780419088

   Nice catch @xicm ,
   
   We may need to check whether 'config.getColumnsEnabledForColumnStatsIndex()' 
contains the `hoodie.table.recordkey.fields` field,
   
   - if 'config.getColumnsEnabledForColumnStatsIndex()' is empty,that means all 
the fields(including the metadata fields)are indexed in col_stats,then we can 
still use `hoodie.table.recordkey.fields` (caution that if 
`hoodie.table.recordkey.fields` is not configured,we can fallback to 
`_hoodie_record_key`);
   - if not empty,we need to check whether  `hoodie.table.recordkey.fields` is 
included in the col_stats,use it if if `hoodie.table.recordkey.fields` is 
included and throws exception otherwise.
   
   It's great if we can supplement some test cases that mentioned in 
https://github.com/apache/hudi/issues/9870 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to