yihua commented on code in PR #9883: URL: https://github.com/apache/hudi/pull/9883#discussion_r1372698435
########## hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java: ########## @@ -160,9 +169,11 @@ public Map<String, Object> generateMetadataForRecord( * @param schema The Avro schema of the record. * @return A mapping containing the metadata. */ - public Map<String, Object> generateMetadataForRecord(T record, Schema schema) { + public Map<String, Object> generateMetadataForRecord(T record, Schema schema, boolean isPartial) { Map<String, Object> meta = new HashMap<>(); meta.put(INTERNAL_META_RECORD_KEY, getRecordKey(record, schema)); + meta.put(INTERNAL_META_SCHEMA, schema); + meta.put(INTERNAL_META_IS_PARTIAL, isPartial); Review Comment: We can. We can take it up in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org