majian1998 commented on PR #9472: URL: https://github.com/apache/hudi/pull/9472#issuecomment-1784704711
@bvaradar: I believe that DeletePartitionUtils.checkForPendingTableServiceActions prevents potential conflicts from occurring earlier. Of course, if this cannot guarantee perfect conflict resolution, I think it is acceptable to sacrifice these performance gains. Detecting conflicts within the transaction does ensure that conflict detection is executed in a serialized manner. However, I still have two questions that I would like to ask. 1.Is performing partition-level conflict detection before ending the transaction a more concise and reasonable modification for this PR? 2.When a conflict occurs, should we directly rollback the conflicting instant and display a message, or should we simply throw an error? Are there any instants where rolling back is not suitable? For example, in the case of consistency hashing clustering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
