bvaradar commented on code in PR #9640:
URL: https://github.com/apache/hudi/pull/9640#discussion_r1376887639
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfigHolder.java:
##########
@@ -72,7 +72,7 @@ public class HiveSyncConfigHolder {
.withDocumentation("Hive metastore url");
public static final ConfigProperty<String> HIVE_AUTO_CREATE_DATABASE =
ConfigProperty
.key("hoodie.datasource.hive_sync.auto_create_database")
- .defaultValue("true")
+ .defaultValue("false")
.markAdvanced()
Review Comment:
It depends on how the tables/databases are organized and how automations are
setup on top of deltastreamer. In our case, we rely on this to create the DB if
not present instead of having a separate job (or manual ways) to create
database. I think it would be safe to leave it like this instead of changing
defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
