danny0405 commented on code in PR #9956:
URL: https://github.com/apache/hudi/pull/9956#discussion_r1379460318
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkCompactionMetrics.java:
##########
@@ -110,16 +110,18 @@ public void endCompaction() {
this.compactionCost = stopTimer(COMPACTION_KEY);
}
- public void setCompactionFailedState(CompactionState compactionState){
- this.compactionFailedState = compactionState.state;
+ public void markCompactionCompleted(CompactionState compactionState) {
+ this.compactionStateSignal = compactionState.state;
+ }
Review Comment:
There is no need to pass around `CompactionState`, just set up the constant
1 or 0 internally, the `CompactionState` can be eliminated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
