PrabhuJoseph commented on code in PR #9946:
URL: https://github.com/apache/hudi/pull/9946#discussion_r1381174885
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/HiveSyncContext.java:
##########
@@ -75,7 +78,12 @@ private HiveSyncContext(Properties props, HiveConf hiveConf)
{
public HiveSyncTool hiveSyncTool() {
HiveSyncMode syncMode =
HiveSyncMode.of(props.getProperty(HIVE_SYNC_MODE.key()));
if (syncMode == HiveSyncMode.GLUE) {
- return new AwsGlueCatalogSyncTool(props, hiveConf);
+ if (ReflectionUtils.hasConstructor(AWS_GLUE_CATALOG_SYNC_TOOL_CLASS,
+ new Class<?>[] {Properties.class,
org.apache.hadoop.conf.Configuration.class})) {
Review Comment:
Thanks for pointing out the unnecessary if condition. I have fixed it in the
latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
