Mathieu1124 commented on a change in pull request #1842:
URL: https://github.com/apache/hudi/pull/1842#discussion_r457470536
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -632,6 +632,33 @@ public FileSystemViewStorageConfig
getClientSpecifiedViewStorageConfig() {
return clientSpecifiedViewStorageConfig;
}
+ /**
+ * Commit call back configs.
+ */
+ public boolean enableWriteCommitCallback() {
+ return
Boolean.parseBoolean(props.getProperty(HoodieWriteCommitCallbackConfig.CALLBACK_ON));
+ }
+
+ public String getCallbackType() {
+ return
props.getProperty(HoodieWriteCommitCallbackConfig.CALLBACK_TYPE_PROP);
+ }
+
+ public String getCallbackClass() {
+ return
props.getProperty(HoodieWriteCommitCallbackConfig.CALLBACK_CLASS_PROP);
+ }
+
+ public String getCallbackRestUrl() {
+ return
props.getProperty(HoodieWriteCommitCallbackConfig.CALLBACK_HTTP_URL_PROP);
+ }
+
+ public int getCallbackRestTimeout() {
+ return
Integer.parseInt(props.getProperty(HoodieWriteCommitCallbackConfig.CALLBACK_TIMEOUT_SECONDS));
+ }
+
+ public String getCallbackRestApiKey() {
+ return props.getProperty(HoodieWriteCommitCallbackConfig.CALLBACK_API_KEY);
+ }
Review comment:
> should we move these methods into
`HoodieHttpWriteCommitCallback.java`, I am worry about the explode of other
callback methods in `HoodieWriteConfig`
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
