codope commented on code in PR #10053:
URL: https://github.com/apache/hudi/pull/10053#discussion_r1390135823
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1000,7 +1000,9 @@ private static List<FileSlice>
getPartitionFileSlices(HoodieTableMetaClient meta
if (mergeFileSlices) {
if
(metaClient.getActiveTimeline().filterCompletedInstants().lastInstant().isPresent())
{
fileSliceStream = fsView.getLatestMergedFileSlicesBeforeOrOn(
- partition,
metaClient.getActiveTimeline().filterCompletedInstants().lastInstant().get().getTimestamp());
+ // including pending compaction instant as the last instant so
that the finished delta commits
+ // that start earlier than the compaction can be queried.
+ partition,
metaClient.getActiveTimeline().filterCompletedAndCompactionInstants().lastInstant().get().getTimestamp());
Review Comment:
you mean to filter **completed** compaction instants and not the **pending**
right? Comment above says pending compaction.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergedReadHandle.java:
##########
@@ -99,7 +99,7 @@ private Option<FileSlice> getLatestFileSlice() {
&&
hoodieTable.getMetaClient().getCommitsTimeline().filterCompletedInstants().lastInstant().isPresent())
{
return Option.fromJavaOptional(hoodieTable
.getHoodieView()
-
.getLatestMergedFileSlicesBeforeOrOn(partitionPathFileIDPair.getLeft(),
instantTime)
+ .getLatestFileSlices(partitionPathFileIDPair.getLeft())
Review Comment:
can it return uncommitted file slices? I think it won't but just to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
