majian1998 commented on code in PR #10101:
URL: https://github.com/apache/hudi/pull/10101#discussion_r1395620121
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/HoodieTimelineArchiver.java:
##########
@@ -117,6 +122,10 @@ public boolean archiveIfRequired(HoodieEngineContext
context, boolean acquireLoc
} else {
LOG.info("No Instants to archive");
}
+ if (success && timerContext != null) {
+ long durationMs = metrics.getDurationInMs(timerContext.stop());
Review Comment:
This does indeed make the style more consistent, but there is one issue –
the archive action does not return any metadata, so we are unable to obtain
information about the cleaned instants. Do we need to modify the return content
of archiveIfRequired to support this improvement?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/HoodieTimelineArchiver.java:
##########
@@ -117,6 +122,10 @@ public boolean archiveIfRequired(HoodieEngineContext
context, boolean acquireLoc
} else {
LOG.info("No Instants to archive");
}
+ if (success && timerContext != null) {
+ long durationMs = metrics.getDurationInMs(timerContext.stop());
Review Comment:
This does indeed make the style more consistent, but there is one issue –
the archive action does not return any metadata, so we are unable to obtain
information about the cleaned instants. Do we need to modify the return content
of archiveIfRequired to support this improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
