hddong commented on a change in pull request #1770:
URL: https://github.com/apache/hudi/pull/1770#discussion_r458821046



##########
File path: 
hudi-cli/src/main/java/org/apache/hudi/cli/utils/SparkTempViewProvider.java
##########
@@ -101,6 +101,17 @@ public void runQuery(String sqlText) {
     }
   }
 
+  @Override
+  public void showAllViews() {
+    try {
+      sqlContext.sql("SHOW TABLES").show(Integer.MAX_VALUE, false);
+    } catch (Throwable ex) {
+      // log full stack trace and rethrow. Without this its difficult to debug 
failures, if any
+      LOG.error("unable to initialize spark context ", ex);

Review comment:
       > IMO, this error description is not correct, right? The throwable not 
only covers the initialization of the spark context
   
   Yes, change it to `unable to get all views`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to