yanghua commented on a change in pull request #1842: URL: https://github.com/apache/hudi/pull/1842#discussion_r458873037
########## File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteCommitCallbackConfig.java ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.config; + +import org.apache.hudi.common.config.DefaultHoodieConfig; + +import java.io.File; +import java.io.FileReader; +import java.io.IOException; +import java.util.Properties; + +/** + * Write callback related config. + */ +public class HoodieWriteCommitCallbackConfig extends DefaultHoodieConfig { + + public static final String CALLBACK_ON = "hoodie.write.commit.callback.on"; + public static final boolean DEFAULT_CALLBACK_ON = false; + + public static final String CALLBACK_CLASS_PROP = "hoodie.write.commit.callback.class"; + public static final String DEFAULT_CALLBACK_CLASS_PROP = "org.apache.hudi.callback.impl.HoodieWriteCommitHttpCallback"; Review comment: Ok, sounds good. ########## File path: hudi-client/src/test/java/org/apache/hudi/testutils/HoodieWriteCommitTestHarness.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.testutils; + +import org.apache.hudi.common.testutils.HoodieCommonTestHarness; +import org.apache.hudi.config.HoodieWriteCommitCallbackConfig; +import org.apache.hudi.config.HoodieWriteConfig; + +import java.io.IOException; + +/** + * The test harness for resource initialization and cleanup. + */ +public class HoodieWriteCommitTestHarness extends HoodieCommonTestHarness { Review comment: ditto ########## File path: hudi-client/src/main/java/org/apache/hudi/callback/util/HoodieCommitCallbackFactory.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.callback.util; + +import org.apache.hudi.callback.HoodieWriteCommitCallback; +import org.apache.hudi.common.util.ReflectionUtils; +import org.apache.hudi.common.util.StringUtils; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.exception.HoodieCommitCallbackException; + +/** + * Factory help to create {@link HoodieWriteCommitCallback}. + */ +public class HoodieCommitCallbackFactory { + public static HoodieWriteCommitCallback create(HoodieWriteConfig config) { + String callbackClass = config.getCallbackClass(); + if (!StringUtils.isNullOrEmpty(callbackClass)) { + Object instance = ReflectionUtils.loadClass(callbackClass, config); + if (!(instance instanceof HoodieWriteCommitCallback)) { + throw new HoodieCommitCallbackException(callbackClass + " is not a subclass of HoodieWriteCommitCallback"); + } + return (HoodieWriteCommitCallback) instance; + } else { + throw new HoodieCommitCallbackException("Parameter 'hoodie.write.commit.callback.class' can not be null or empty"); Review comment: Can we reference `CALLBACK_CLASS_PROP ` not `hoodie.write.commit.callback.class`? What's more, it's not ** Parameter**, it's a config option. Let's say e.g. `The value of the config option xxx can not be ....`? Does it make sense? ########## File path: hudi-client/src/test/java/org/apache/hudi/callback/http/TestHoodieWriteCommitHttpCallback.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.callback.http; + +import org.apache.hudi.callback.impl.HoodieWriteCommitHttpCallback; +import org.apache.hudi.testutils.HoodieWriteCommitTestHarness; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.io.IOException; + +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; + +/** + * Unit test for {@link HoodieWriteCommitHttpCallback}. + */ +public class TestHoodieWriteCommitHttpCallback extends HoodieWriteCommitTestHarness { Review comment: IMO, it's not necessary. We can remove it. ########## File path: hudi-client/src/main/java/org/apache/hudi/callback/util/HoodieCommitCallbackFactory.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.callback.util; + +import org.apache.hudi.callback.HoodieWriteCommitCallback; +import org.apache.hudi.common.util.ReflectionUtils; +import org.apache.hudi.common.util.StringUtils; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.exception.HoodieCommitCallbackException; + +/** + * Factory help to create {@link HoodieWriteCommitCallback}. + */ +public class HoodieCommitCallbackFactory { + public static HoodieWriteCommitCallback create(HoodieWriteConfig config) { + String callbackClass = config.getCallbackClass(); + if (!StringUtils.isNullOrEmpty(callbackClass)) { + Object instance = ReflectionUtils.loadClass(callbackClass, config); + if (!(instance instanceof HoodieWriteCommitCallback)) { + throw new HoodieCommitCallbackException(callbackClass + " is not a subclass of HoodieWriteCommitCallback"); Review comment: Let's use `HoodieWriteCommitHttpCallback.class.getSimpleName() ` to replace the hard code `HoodieWriteCommitCallback `? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
