jonvex commented on code in PR #10137: URL: https://github.com/apache/hudi/pull/10137#discussion_r1408244066
########## hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieSimpleFileGroupRecordBuffer.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.table.read; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.engine.HoodieReaderContext; +import org.apache.hudi.common.model.DeleteRecord; +import org.apache.hudi.common.model.HoodieRecordMerger; +import org.apache.hudi.common.table.log.KeySpec; +import org.apache.hudi.common.table.log.block.HoodieDataBlock; +import org.apache.hudi.common.table.log.block.HoodieDeleteBlock; +import org.apache.hudi.common.util.Option; + +import org.apache.avro.Schema; + +import java.io.IOException; +import java.util.Map; + +public class HoodieSimpleFileGroupRecordBuffer<T> extends HoodieBaseFileGroupRecordBuffer<T> { + public HoodieSimpleFileGroupRecordBuffer(HoodieReaderContext<T> readerContext, Schema readerSchema, Schema baseFileSchema, + Option<String> partitionNameOverrideOpt, Option<String[]> partitionPathFieldOpt, HoodieRecordMerger recordMerger, + TypedProperties payloadProps) { + super(readerContext, readerSchema, baseFileSchema, partitionNameOverrideOpt, partitionPathFieldOpt, recordMerger, payloadProps); + } + + @Override + protected boolean doHasNext() throws IOException { + if (baseFileIterator.hasNext()) { + nextRecord = readerContext.seal(baseFileIterator.next()); + return true; + } + return false; + } + + @Override + public BufferType getBufferType() { + return BufferType.SIMPLE; + } + + @Override + public void processDataBlock(HoodieDataBlock dataBlock, Option<KeySpec> keySpecOpt) throws IOException { + throw new IllegalStateException("processDataBlock should never be called from HoodieSimpleFileGroupRecordBuffer"); Review Comment: HoodieSimpleFileGroupRecordBuffer is used when there are no log files, so none of these methods should be called -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
