linliu-code commented on code in PR #10109: URL: https://github.com/apache/hudi/pull/10109#discussion_r1408768596
########## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieHadoopFsRelationFactory.scala: ########## @@ -231,28 +231,23 @@ class HoodieMergeOnReadSnapshotHadoopFsRelationFactory(override val sqlContext: ) val mandatoryFields: Seq[String] = mandatoryFieldsForMerging - val fileGroupReaderBasedFileFormat = new HoodieFileGroupReaderBasedParquetFileFormat( - tableState, HoodieTableSchema(tableStructSchema, tableAvroSchema.toString, internalSchemaOpt), - metaClient.getTableConfig.getTableName, mergeType, mandatoryFields, - true, isBootstrap, false, shouldUseRecordPosition, Seq.empty) - - val newHoodieParquetFileFormat = new NewHoodieParquetFileFormat(sparkSession.sparkContext.broadcast(tableState), - sparkSession.sparkContext.broadcast(HoodieTableSchema(tableStructSchema, tableAvroSchema.toString, internalSchemaOpt)), - metaClient.getTableConfig.getTableName, mergeType, mandatoryFields, true, isBootstrap, false, Seq.empty) - - val multipleBaseFileFormat = new HoodieMultipleBaseFileFormat(sparkSession.sparkContext.broadcast(tableState), - sparkSession.sparkContext.broadcast(HoodieTableSchema(tableStructSchema, tableAvroSchema.toString, internalSchemaOpt)), - metaClient.getTableConfig.getTableName, mergeType, mandatoryFields, true, false, Seq.empty) override def buildFileIndex(): FileIndex = fileIndex override def buildFileFormat(): FileFormat = { if (fileGroupReaderEnabled && !isBootstrap) { - fileGroupReaderBasedFileFormat + new HoodieFileGroupReaderBasedParquetFileFormat( Review Comment: Added a brief description in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org